Issue 1130383003: Brings defines for the GN build in line with GYP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1130383003: Brings defines for the GN build in line with GYP. (Closed)

Created:
5 years, 7 months ago by brettw

Modified:
5 years, 7 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Brings defines for the GN build in line with GYP. The GYP and GN build's defines have diverged. THis brings GN's defines in line with GYP's current set. R=jshin@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/ce41627e388fb46ab49671bd16a5db81dcd75a71

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	BUILD.gn	View		2 chunks	+16 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

brettw

5 years, 7 months ago (2015-05-11 20:30:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ce41627e388fb46ab49671bd16a5db81dcd75a71 (presubmit successful).