Returning Corresponding Error Message when their is error in OpenTab.

Returning Corresponding Error Message when their is error in OpenTab.

This is for TODO for returning error message when error occurs in OpenTab().

BUG=485875
Committed: https://crrev.com/21895c01cffc939c13935599bb1bfc880e78453e
Cr-Commit-Position: refs/heads/master@{#329115}

[Deepak, 2015-05-08 05:31:45]

deepak.m1@samsung.com changed reviewers:
+ rockot@chromium.org

[Deepak, 2015-05-08 05:31:45]

Please review, these changes are to address few TODO's.
Thanks

[Ken Rockot(use gerrit already), 2015-05-08 19:33:09]

lgtm

https://codereview.chromium.org/1130373002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/1130373002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_tab_util.cc:166: keys::kTabNotFoundError,
base::IntToString(opener_id));
nit: This formatting is incorrect. Running 'git cl format' should automate
formatting for you.

[Deepak, 2015-05-09 04:52:25]

@Ken
nit Addressed.
Thanks for review.

https://codereview.chromium.org/1130373002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/1130373002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_tab_util.cc:166: keys::kTabNotFoundError,
base::IntToString(opener_id));
On 2015/05/08 19:33:09, Ken Rockot wrote:
> nit: This formatting is incorrect. Running 'git cl format' should automate
> formatting for you.

Done.

[Deepak, 2015-05-09 04:52:31]

The CQ bit was checked by deepak.m1@samsung.com

[Deepak, 2015-05-09 04:52:32]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1130373002/#ps60001
(title: "Addressing nit.")

[commit-bot: I haz the power, 2015-05-09 04:56:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130373002/60001

[commit-bot: I haz the power, 2015-05-09 12:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-09 12:15:46]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Deepak, 2015-05-11 02:32:37]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-05-11 02:35:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130373002/60001

[commit-bot: I haz the power, 2015-05-11 08:11:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-11 08:12:33]

Patchset 4 (id:??) landed as
https://crrev.com/21895c01cffc939c13935599bb1bfc880e78453e
Cr-Commit-Position: refs/heads/master@{#329115}