Issue 1130353013: Attempt to fix bad dependency in Sky build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1130353013: Attempt to fix bad dependency in Sky build (Closed)

Created:
5 years, 7 months ago by abarth-chromium

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Attempt to fix bad dependency in Sky build Several people have run into trouble building Sky because of a missing dependency in the build. From inspection, it looks like this might fix the issue, but it's hard to be sure without being able to reproduce the issue locally. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/575fca242e655cad89a5537bc4c2b53ef63b629a

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sky/engine/bindings/BUILD.gn	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 7 months ago (2015-05-19 22:44:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
575fca242e655cad89a5537bc4c2b53ef63b629a (presubmit successful).