chrome/browser/ui/app_list/extension_app_item.cc - Issue 1130353010: Remove deprecated ExtensionService::GetInstalledExtension() usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_app_item.cc

Issue 1130353010: Remove deprecated ExtensionService::GetInstalledExtension() usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.h ('K') | « chrome/browser/ui/app_list/app_list_syncable_service.cc ('k') | chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/extension_app_item.cc

diff --git a/chrome/browser/ui/app_list/extension_app_item.cc b/chrome/browser/ui/app_list/extension_app_item.cc

index a15893f12b5b20a5ba07af72b0f4a4b4502e78db..f8e35a9ba2722ec7850c89e9ed7a3f0e2e3aff4b 100644

--- a/chrome/browser/ui/app_list/extension_app_item.cc

+++ b/chrome/browser/ui/app_list/extension_app_item.cc

@@ -5,7 +5,6 @@

#include "chrome/browser/ui/app_list/extension_app_item.h"

#include "base/prefs/pref_service.h"

-#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/extensions/launch_util.h"

#include "chrome/browser/profiles/profile.h"

@@ -19,7 +18,7 @@

#include "content/public/browser/user_metrics.h"

#include "extensions/browser/app_sorting.h"

#include "extensions/browser/extension_prefs.h"

-#include "extensions/browser/extension_system.h"

+#include "extensions/browser/extension_registry.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_icon_set.h"

#include "extensions/common/manifest_handlers/icons_handler.h"

@@ -229,9 +228,10 @@ void ExtensionAppItem::Move(const ExtensionAppItem* prev,

}

const Extension* ExtensionAppItem::GetExtension() const {

- const ExtensionService* service =

- extensions::ExtensionSystem::Get(profile_)->extension_service();

- const Extension* extension = service->GetInstalledExtension(extension_id_);

+ const extensions::ExtensionRegistry* registry =

+ extensions::ExtensionRegistry::Get(profile_);

+ const Extension* extension = registry->GetInstalledExtension(

+ extension_id_);

return extension;

}