Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 1130353010: Remove deprecated ExtensionService::GetInstalledExtension() usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/app_list_controller_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 0b97b1ad67f57ce7753c6d0a1bf3230bdd64c9c9..28ced69ca06b451f4cde04277a2c168899e02d74 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -115,7 +115,7 @@ class ExtensionServiceInterface
// Looks up an extension by ID, regardless of whether it's enabled,
// disabled, blacklisted, or terminated. Use instead:
//
- // ExtensionRegistry::GetExtensionById(id, ExtensionRegistry::EVERYTHING).
+ // ExtensionRegistry::GetInstalledExtension(id).
virtual const extensions::Extension* GetInstalledExtension(
const std::string& id) const = 0;
@@ -180,7 +180,7 @@ class ExtensionService
public extensions::ExtensionManagement::Observer {
public:
// Attempts to uninstall an extension from a given ExtensionService. Returns
- // true iff the target extension exists.
+ // true if the target extension exists.
not at google - send to devlin 2015/06/04 17:41:32 "iff" is correct, it means "if and only if".
babu 2015/06/05 11:16:25 Acknowledged. Thanks!
static bool UninstallExtensionHelper(ExtensionService* extensions_service,
const std::string& extension_id,
extensions::UninstallReason reason);
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/app_list_controller_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698