Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1130353009: Teach SkyView how to load the main script (Closed)

Created:
5 years, 7 months ago by abarth-chromium
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Teach SkyView how to load the main script This CL implements SkyView::Load to start executing Sky content directly from Dart's main(). This code isn't currently wired up to anything, so it's not yet tested. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0727fce97e6af214a4231760557140a0fd8b31fb

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
M sky/engine/core/script/dart_controller.h View 4 chunks +8 lines, -0 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 2 chunks +19 lines, -1 line 0 comments Download
M sky/engine/core/script/dart_loader.h View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/script/dart_loader.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M sky/engine/public/sky/sky_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M sky/engine/public/sky/sky_view.cc View 2 chunks +8 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 7 months ago (2015-05-18 22:48:18 UTC) #1
eseidel
lgtm https://codereview.chromium.org/1130353009/diff/1/sky/engine/public/sky/sky_view.cc File sky/engine/public/sky/sky_view.cc (right): https://codereview.chromium.org/1130353009/diff/1/sky/engine/public/sky/sky_view.cc#newcode22 sky/engine/public/sky/sky_view.cc:22: dart_controller_->ClearForClose(); Why is this separate from the destructor?
5 years, 7 months ago (2015-05-19 17:20:37 UTC) #2
abarth-chromium
https://codereview.chromium.org/1130353009/diff/1/sky/engine/public/sky/sky_view.cc File sky/engine/public/sky/sky_view.cc (right): https://codereview.chromium.org/1130353009/diff/1/sky/engine/public/sky/sky_view.cc#newcode22 sky/engine/public/sky/sky_view.cc:22: dart_controller_->ClearForClose(); On 2015/05/19 at 17:20:37, eseidel wrote: > Why ...
5 years, 7 months ago (2015-05-19 17:26:49 UTC) #3
abarth-chromium
5 years, 7 months ago (2015-05-19 17:55:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0727fce97e6af214a4231760557140a0fd8b31fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698