Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1130353005: Makes content handlers see requestor url (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes content handlers see requestor url Prior to this fix the incoming connection to the content handler saw an empty requesting url. This change makes the requesting url correspond to the url of the first app connecting to the content handler. BUG=none TEST=covered by test R=ben@chromium.org Committed: https://crrev.com/57439937b14ad4362ab4dde3f828b7017f4aad8d Cr-Commit-Position: refs/heads/master@{#329441}

Patch Set 1 #

Patch Set 2 : merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -9 lines) Patch
M mojo/runner/context.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/runner/context.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/runner/native_runner_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/shell/application_manager.h View 1 4 chunks +8 lines, -1 line 0 comments Download
M mojo/shell/application_manager.cc View 1 7 chunks +17 lines, -8 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 8 chunks +80 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
5 years, 7 months ago (2015-05-12 17:40:58 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 7 months ago (2015-05-12 17:57:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130353005/20001
5 years, 7 months ago (2015-05-12 18:03:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 18:08:16 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 18:08:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57439937b14ad4362ab4dde3f828b7017f4aad8d
Cr-Commit-Position: refs/heads/master@{#329441}

Powered by Google App Engine
This is Rietveld 408576698