Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1130353004: Reshow the notification after validating dangerous download (Closed)

Created:
5 years, 7 months ago by yoshiki
Modified:
5 years, 7 months ago
Reviewers:
asanka
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reshow the notification after validating dangerous download This patch adds the code to reshow the notification after user clicks "Keep" button on dangerous download notification. This patch also adds the tests of dangerous downloads. BUG=480489 TEST=browsertest run Committed: https://crrev.com/9f853ad8b093476f2ec2a7b29f227315a266b780 Cr-Commit-Position: refs/heads/master@{#329821}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -5 lines) Patch
M chrome/browser/download/notification/download_notification_browsertest.cc View 1 6 chunks +110 lines, -5 lines 0 comments Download
M chrome/browser/download/notification/download_notification_item.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
yoshiki
Asanka, PTAL. Thanks.
5 years, 7 months ago (2015-05-12 17:56:47 UTC) #4
asanka
lgtm
5 years, 7 months ago (2015-05-14 03:48:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130353004/40001
5 years, 7 months ago (2015-05-14 06:04:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/67304) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-14 06:07:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130353004/60001
5 years, 7 months ago (2015-05-14 07:42:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 7 months ago (2015-05-14 08:55:59 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 08:56:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f853ad8b093476f2ec2a7b29f227315a266b780
Cr-Commit-Position: refs/heads/master@{#329821}

Powered by Google App Engine
This is Rietveld 408576698