Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1130353003: Remove --enable-spdy4 and --enable-npn-http command line flags. (Closed)

Created:
5 years, 7 months ago by Bence
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --enable-spdy4 and --enable-npn-http command line flags. Remove --enable-spdy4 and --enable-npn-http command line flags that used to force enable and disable both of HTTP/2 and SPDY/3.1, respectively. They are obsolete because * these protocols are not experimental any more, * they are enabled by default, * usage of disabling flag is very low and it is unlikely that these flags will ever be needed for debugging. BUG= Committed: https://crrev.com/f7ed9b85d9b6ed0d0dfa80d9838890200c399c07 Cr-Commit-Position: refs/heads/master@{#329407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 7 months ago (2015-05-12 14:13:58 UTC) #2
Ryan Hamilton
lgtm
5 years, 7 months ago (2015-05-12 14:16:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130353003/1
5 years, 7 months ago (2015-05-12 14:19:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 15:04:21 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 15:04:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7ed9b85d9b6ed0d0dfa80d9838890200c399c07
Cr-Commit-Position: refs/heads/master@{#329407}

Powered by Google App Engine
This is Rietveld 408576698