Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1130343005: cc: Optimize OnePriorityRectIterator a little bit. (Closed)

Created:
5 years, 7 months ago by vmpstr
Modified:
5 years, 7 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Optimize OnePriorityRectIterator a little bit. This is a pretty small optimization, but it saves a few struct copies, which seems to make a small difference (~1% improvement) in a targeted perftest that runs this function. R=enne BUG=488636 Committed: https://crrev.com/1172ff24a17ca9e8d0778cf1ab277a8ddb38558d Cr-Commit-Position: refs/heads/master@{#330637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M cc/tiles/tiling_set_raster_queue_all.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/tiles/tiling_set_raster_queue_all.cc View 2 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
vmpstr
Please take a look. The improvement from this is very minor. A test that basically ...
5 years, 7 months ago (2015-05-19 20:05:56 UTC) #1
vmpstr
On 2015/05/19 20:05:56, vmpstr wrote: > Please take a look. The improvement from this is ...
5 years, 7 months ago (2015-05-19 20:29:28 UTC) #2
enne (OOO)
lgtm
5 years, 7 months ago (2015-05-19 21:35:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130343005/1
5 years, 7 months ago (2015-05-19 21:38:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 22:32:33 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:34:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1172ff24a17ca9e8d0778cf1ab277a8ddb38558d
Cr-Commit-Position: refs/heads/master@{#330637}

Powered by Google App Engine
This is Rietveld 408576698