Issue 1130313003: [BackgroundSync] Fix accidental fall-through in getRegistrations callack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1130313003: [BackgroundSync] Fix accidental fall-through in getRegistrations callack (Closed)

Created:
5 years, 7 months ago by iclelland

Modified:
5 years, 7 months ago

Reviewers:
jkarlin

CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[BackgroundSync] Fix accidental fall-through in getRegistrations callack There was a missing break in the switch for handling the error state in BackgroundSyncProvider::GetRegistrationsCallback. BUG=488451 Committed: https://crrev.com/8afd010d637bd63900e6c4ad5e9e03af5842c194 Cr-Commit-Position: refs/heads/master@{#330088}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	content/child/background_sync/background_sync_provider.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130313003/1

5 years, 7 months ago (2015-05-15 13:03:55 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-15 13:49:10 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8afd010d637bd63900e6c4ad5e9e03af5842c194
Cr-Commit-Position: refs/heads/master@{#330088}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages