Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1130313002: Update subzero bitcode parser to use new API for bitstream reading. (Closed)

Created:
5 years, 7 months ago by Karl
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update subzero bitcode parser to use new API for bitstream reading. Dependent on https://codereview.chromium.org/1122423005 being committed first. BUG=https://code.google.com/p/nativeclient/issues/detail?id=4164 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b33a2af2076ec1e24030f2a330fd547a1823b884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/PNaClTranslator.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Karl
5 years, 7 months ago (2015-05-07 22:36:25 UTC) #2
jvoung (off chromium)
Thought it looked like native-client-reviews wasn't on the CC list for some reason so added ...
5 years, 7 months ago (2015-05-11 20:22:38 UTC) #4
jvoung (off chromium)
lgtm
5 years, 7 months ago (2015-05-11 20:33:25 UTC) #5
Karl
5 years, 7 months ago (2015-05-12 15:26:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b33a2af2076ec1e24030f2a330fd547a1823b884 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698