Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130303004: cc: Remove unused Tile ctor parameter (raster_source). (Closed)

Created:
5 years, 7 months ago by vmpstr
Modified:
5 years, 7 months ago
Reviewers:
hendrikw
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove unused Tile ctor parameter (raster_source). Raster source moved to be in PrioritizedTile returned by the priority queues. This patch cleans up the ctor to remove the now unused raster source parameter. R=hendrikw Committed: https://crrev.com/012d08168d857edb81ef821f92281b200a491aa2 Cr-Commit-Position: refs/heads/master@{#329697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M cc/debug/frame_viewer_instrumentation.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/gpu_rasterizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/prioritized_tile.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/tile.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/resources/tile.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/tile_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
vmpstr
Please take a look.
5 years, 7 months ago (2015-05-13 17:19:25 UTC) #1
hendrikw
On 2015/05/13 17:19:25, vmpstr wrote: > Please take a look. LGTM
5 years, 7 months ago (2015-05-13 17:23:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130303004/1
5 years, 7 months ago (2015-05-13 17:26:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 19:31:15 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:31:58 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/012d08168d857edb81ef821f92281b200a491aa2
Cr-Commit-Position: refs/heads/master@{#329697}

Powered by Google App Engine
This is Rietveld 408576698