Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: src/hydrogen.cc

Issue 1130283002: [strong] Disallow implicit conversions for comparison (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/hydrogen.h" 5 #include "src/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 11191 matching lines...) Expand 10 before | Expand all | Expand 10 after
11202 } else if (combined_type->Is(Type::String())) { 11202 } else if (combined_type->Is(Type::String())) {
11203 BuildCheckHeapObject(left); 11203 BuildCheckHeapObject(left);
11204 Add<HCheckInstanceType>(left, HCheckInstanceType::IS_STRING); 11204 Add<HCheckInstanceType>(left, HCheckInstanceType::IS_STRING);
11205 BuildCheckHeapObject(right); 11205 BuildCheckHeapObject(right);
11206 Add<HCheckInstanceType>(right, HCheckInstanceType::IS_STRING); 11206 Add<HCheckInstanceType>(right, HCheckInstanceType::IS_STRING);
11207 HStringCompareAndBranch* result = 11207 HStringCompareAndBranch* result =
11208 New<HStringCompareAndBranch>(left, right, op); 11208 New<HStringCompareAndBranch>(left, right, op);
11209 return result; 11209 return result;
11210 } else { 11210 } else {
11211 if (combined_rep.IsTagged() || combined_rep.IsNone()) { 11211 if (combined_rep.IsTagged() || combined_rep.IsNone()) {
11212 HCompareGeneric* result = Add<HCompareGeneric>(left, right, op); 11212 HCompareGeneric* result =
11213 Add<HCompareGeneric>(left, right, op, function_language_mode());
11213 result->set_observed_input_representation(1, left_rep); 11214 result->set_observed_input_representation(1, left_rep);
11214 result->set_observed_input_representation(2, right_rep); 11215 result->set_observed_input_representation(2, right_rep);
11215 if (result->HasObservableSideEffects()) { 11216 if (result->HasObservableSideEffects()) {
11216 if (push_sim_result == PUSH_BEFORE_SIMULATE) { 11217 if (push_sim_result == PUSH_BEFORE_SIMULATE) {
11217 Push(result); 11218 Push(result);
11218 AddSimulate(bailout_id, REMOVABLE_SIMULATE); 11219 AddSimulate(bailout_id, REMOVABLE_SIMULATE);
11219 Drop(1); 11220 Drop(1);
11220 } else { 11221 } else {
11221 AddSimulate(bailout_id, REMOVABLE_SIMULATE); 11222 AddSimulate(bailout_id, REMOVABLE_SIMULATE);
11222 } 11223 }
(...skipping 1929 matching lines...) Expand 10 before | Expand all | Expand 10 after
13152 if (ShouldProduceTraceOutput()) { 13153 if (ShouldProduceTraceOutput()) {
13153 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13154 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13154 } 13155 }
13155 13156
13156 #ifdef DEBUG 13157 #ifdef DEBUG
13157 graph_->Verify(false); // No full verify. 13158 graph_->Verify(false); // No full verify.
13158 #endif 13159 #endif
13159 } 13160 }
13160 13161
13161 } } // namespace v8::internal 13162 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698