Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1130253012: [Android] Make BatteryStatusManagerTest compilable on M (Closed)

Created:
5 years, 7 months ago by timvolodine
Modified:
5 years, 7 months ago
Reviewers:
Yaron
CC:
chromium-reviews, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make BatteryStatusManagerTest compilable on M BatteryStatusManagerTest does not compile on M because of the changes to the BatteryManager class. This patch introduces AndroidBatteryManagerWrapper to make the system battery manager testable on M. BUG=488690 Committed: https://crrev.com/2f08ccf895d5c96019da0cd6cfea23cb6b34c18f Cr-Commit-Position: refs/heads/master@{#330723}

Patch Set 1 #

Patch Set 2 : fix formatting #

Patch Set 3 : remove unused mAndroidBatteryManager field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -42 lines) Patch
M device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java View 1 5 chunks +28 lines, -16 lines 0 comments Download
M device/battery/android/javatests/src/org/chromium/device/battery/BatteryStatusManagerTest.java View 1 2 8 chunks +28 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
timvolodine
5 years, 7 months ago (2015-05-18 14:45:13 UTC) #2
Yaron
lgtm thanks
5 years, 7 months ago (2015-05-19 13:55:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130253012/20001
5 years, 7 months ago (2015-05-19 17:25:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/78207)
5 years, 7 months ago (2015-05-19 18:14:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130253012/40001
5 years, 7 months ago (2015-05-20 10:39:58 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 10:43:51 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 10:44:49 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2f08ccf895d5c96019da0cd6cfea23cb6b34c18f
Cr-Commit-Position: refs/heads/master@{#330723}

Powered by Google App Engine
This is Rietveld 408576698