Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1130253010: Fix UMA reporting for permission granted stats with bubbles (Closed)

Created:
5 years, 7 months ago by Miguel Garcia
Modified:
5 years, 7 months ago
CC:
chromium-reviews, markusheintz_, mlamouri (slow - plz ping), Bernhard Bauer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UMA reporting for permission granted stats with bubbles BUG= TBR=bauerb Committed: https://crrev.com/c36aa5312d4f6a7a21d05610a5edb69993d20c03 Cr-Commit-Position: refs/heads/master@{#330076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/content_settings/permission_context_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Miguel Garcia
5 years, 7 months ago (2015-05-14 11:11:32 UTC) #2
Peter Beverloo
lgtm
5 years, 7 months ago (2015-05-14 11:18:14 UTC) #4
Miguel Garcia
+Markus for Owners approval
5 years, 7 months ago (2015-05-14 11:42:09 UTC) #7
Miguel Garcia
I am landing this, it's a trivial bug fix and I want to make sure ...
5 years, 7 months ago (2015-05-15 10:37:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130253010/1
5 years, 7 months ago (2015-05-15 10:37:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 11:19:22 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c36aa5312d4f6a7a21d05610a5edb69993d20c03 Cr-Commit-Position: refs/heads/master@{#330076}
5 years, 7 months ago (2015-05-15 11:20:13 UTC) #12
Bernhard Bauer
lgtm
5 years, 7 months ago (2015-05-15 15:05:02 UTC) #14
Miguel Garcia
5 years, 7 months ago (2015-05-15 15:07:56 UTC) #15
Message was sent while issue was closed.
Thanks Bernhard!

On Fri, May 15, 2015 at 4:05 PM, <bauerb@chromium.org> wrote:

> lgtm
>
>
>
> https://codereview.chromium.org/1130253010/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698