Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130253006: Fix build after revert at 28332. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix build after revert at 28332. TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/0208b8e3a1d7ce393308866386ac8d94f85faa05 Cr-Commit-Position: refs/heads/master@{#28333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/js2c.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 7 months ago (2015-05-11 08:48:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130253006/1
5 years, 7 months ago (2015-05-11 08:49:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 08:50:46 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0208b8e3a1d7ce393308866386ac8d94f85faa05 Cr-Commit-Position: refs/heads/master@{#28333}
5 years, 7 months ago (2015-05-11 08:51:00 UTC) #5
Michael Achenbach
5 years, 7 months ago (2015-05-11 09:31:55 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698