Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1130213004: [Smart Lock] Make android URL prettifying util available on ios. (Closed)

Created:
5 years, 7 months ago by melandory
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, gcasto+watchlist_chromium.org, michaelpg+watch-options_chromium.org, mkwst+watchlist-passwords_chromium.org, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Make android URL prettifying util available on ios. Move GetHumanReadableOrigin method to affliation utils in order to make it available in ios. This CL requires GetHumanReadableOrigin on ios: https://chromereviews.googleplex.com/191547013/ BUG=486736 Committed: https://crrev.com/ab8c5abf63abcc2c60046055d3bb24b36237c8d9 Cr-Commit-Position: refs/heads/master@{#330343}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Rebased on top of master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -93 lines) Patch
M chrome/browser/android/password_ui_view_android.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.h View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.cc View 2 chunks +0 lines, -11 lines 0 comments Download
D chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/affiliation_utils.h View 2 chunks +13 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/affiliation_utils.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/affiliation_utils_unittest.cc View 1 3 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
melandory
sky@chromium.org: Please review changes in chrome/chrome_tests_unit.gypi mkwst@chromium.org: chrome/browser/ui/passwords/manage_passwords_view_utils.h chrome/browser/ui/passwords/manage_passwords_view_utils.cc chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc components/password_manager/core/browser/affiliation_utils.h components/password_manager/core/browser/affiliation_utils.cc components/password_manager/core/browser/affiliation_utils_unittest.cc bauerb@chromium.org: chrome/browser/ui/webui/options/password_manager_handler.cc ...
5 years, 7 months ago (2015-05-13 22:07:30 UTC) #3
sky
.gypi has owner=*, anyone can review it.
5 years, 7 months ago (2015-05-13 23:44:41 UTC) #4
Mike West
Moving this around to the module's core/ LGTM. Nit: s/humar/human/ in the CL description. Nit: ...
5 years, 7 months ago (2015-05-14 10:16:14 UTC) #5
melandory
-bauerb who is OOO +estade for chrome/browser/ui/webui/options/password_manager_handler.cc +newt chrome/browser/android/password_ui_view_android.cc
5 years, 7 months ago (2015-05-14 10:27:33 UTC) #8
newt (away)
password_ui_view_android.cc lgtm
5 years, 7 months ago (2015-05-14 20:50:42 UTC) #9
Evan Stade
chrome/browser/ui/webui/options/password_manager_handler.cc lgtm
5 years, 7 months ago (2015-05-14 21:56:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130213004/40001
5 years, 7 months ago (2015-05-18 08:40:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/25979) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-18 08:43:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130213004/60001
5 years, 7 months ago (2015-05-18 09:40:28 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-18 09:58:52 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:34:19 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab8c5abf63abcc2c60046055d3bb24b36237c8d9
Cr-Commit-Position: refs/heads/master@{#330343}

Powered by Google App Engine
This is Rietveld 408576698