Add runtime dependency extraction for GN.

Add runtime dependency extraction for GN.

GN will now compute the list of files required for targets to run based on dependencies and data files listed on the targets.

This is exposed via the "gn desc ... runtime_deps" command, and via a new switch that will write runtime deps files for specific targets at generation time.

Committed: https://crrev.com/0db9185ce7bc14d96ce262978912a41941f46522
Cr-Commit-Position: refs/heads/master@{#329976}

[brettw, 2015-05-13 18:07:58]

.

[brettw, 2015-05-13 22:18:12]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2015-05-13 22:18:19]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-13 22:19:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130183007/80001

[scottmg, 2015-05-13 22:43:26]

https://codereview.chromium.org/1130183007/diff/80001/tools/gn/runtime_deps.cc
File tools/gn/runtime_deps.cc (right):

https://codereview.chromium.org/1130183007/diff/80001/tools/gn/runtime_deps.c...
tools/gn/runtime_deps.cc:86: 
what about Target::COPY_FILES?

https://codereview.chromium.org/1130183007/diff/80001/tools/gn/runtime_deps.c...
tools/gn/runtime_deps.cc:147: "  targets that are \"deps\" or \"public_deps\"
will have only their\n"
I don't understand this part (and the tests for it), wouldn't the outputs
normally be the runtime dependency, not the inputs?

[commit-bot: I haz the power, 2015-05-13 22:44:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 22:44:35]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[brettw, 2015-05-14 16:33:44]

https://codereview.chromium.org/1130183007/diff/80001/tools/gn/runtime_deps.cc
File tools/gn/runtime_deps.cc (right):

https://codereview.chromium.org/1130183007/diff/80001/tools/gn/runtime_deps.c...
tools/gn/runtime_deps.cc:147: "  targets that are \"deps\" or \"public_deps\"
will have only their\n"
On 2015/05/13 22:43:26, scottmg wrote:
> I don't understand this part (and the tests for it), wouldn't the outputs
> normally be the runtime dependency, not the inputs?

The inputs are never a runtime dependency. Please let me know if this is
mentioned or implied anywhere.

The difference here is "outputs" vs. "data". "data" is always a runtime
dependency in any target. "outputs" of actions are only runtime dependencies if
that target is a datadep.

[brettw, 2015-05-14 16:37:27]

New snap up

https://codereview.chromium.org/1130183007/diff/80001/tools/gn/runtime_deps.cc
File tools/gn/runtime_deps.cc (right):

https://codereview.chromium.org/1130183007/diff/80001/tools/gn/runtime_deps.c...
tools/gn/runtime_deps.cc:86: 
On 2015/05/13 22:43:26, scottmg wrote:
> what about Target::COPY_FILES?

Good question, I added COPY so it works like actions.

[scottmg, 2015-05-14 17:42:45]

lgtm

https://codereview.chromium.org/1130183007/diff/100001/tools/gn/runtime_deps_...
File tools/gn/runtime_deps_unittest.cc (right):

https://codereview.chromium.org/1130183007/diff/100001/tools/gn/runtime_deps_...
tools/gn/runtime_deps_unittest.cc:178: ASSERT_TRUE(dep.OnResolved(&err));
add a copy dependency here?

[brettw, 2015-05-14 20:49:58]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-05-14 20:49:58]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1130183007/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-05-14 20:50:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130183007/120001

[commit-bot: I haz the power, 2015-05-14 21:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 21:15:57]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[brettw, 2015-05-14 22:41:38]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-05-14 22:41:39]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1130183007/#ps140001
(title: "moar parens for visual studio")

[commit-bot: I haz the power, 2015-05-14 22:42:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130183007/140001

[commit-bot: I haz the power, 2015-05-14 23:02:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 23:02:31]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[brettw, 2015-05-14 23:06:19]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-05-14 23:06:19]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1130183007/#ps160001
(title: "make msvc happy")

[commit-bot: I haz the power, 2015-05-14 23:07:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130183007/160001

[commit-bot: I haz the power, 2015-05-14 23:40:30]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-05-14 23:42:02]

Patchset 9 (id:??) landed as
https://crrev.com/0db9185ce7bc14d96ce262978912a41941f46522
Cr-Commit-Position: refs/heads/master@{#329976}