Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130183003: Notify upload progress from batch request to its child requests. (Closed)

Created:
5 years, 7 months ago by hirono
Modified:
5 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify upload progress from batch request to its child requests. BUG=451917 TEST=DriveApiRequestsTest.BatchUploadRequestProgress Committed: https://crrev.com/21c8c94ed1602209e7601d57b2e2c451d3294bbe Cr-Commit-Position: refs/heads/master@{#329351}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Addressed comments and fix msan test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -16 lines) Patch
M google_apis/drive/base_requests.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M google_apis/drive/base_requests.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 1 2 3 chunks +11 lines, -1 line 0 comments Download
M google_apis/drive/drive_api_requests.cc View 1 2 4 chunks +32 lines, -5 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 1 2 3 chunks +82 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
hirono
PTAL, thanks!
5 years, 7 months ago (2015-05-11 12:58:51 UTC) #2
kinaba
https://codereview.chromium.org/1130183003/diff/20001/google_apis/drive/drive_api_requests.cc File google_apis/drive/drive_api_requests.cc (right): https://codereview.chromium.org/1130183003/diff/20001/google_apis/drive/drive_api_requests.cc#newcode1297 google_apis/drive/drive_api_requests.cc:1297: child_requests_[i].data_position += part_data_positions[i]; position + position sounds a bit ...
5 years, 7 months ago (2015-05-11 13:17:35 UTC) #3
hirono
Thank you! https://codereview.chromium.org/1130183003/diff/20001/google_apis/drive/drive_api_requests.cc File google_apis/drive/drive_api_requests.cc (right): https://codereview.chromium.org/1130183003/diff/20001/google_apis/drive/drive_api_requests.cc#newcode1297 google_apis/drive/drive_api_requests.cc:1297: child_requests_[i].data_position += part_data_positions[i]; On 2015/05/11 13:17:35, kinaba ...
5 years, 7 months ago (2015-05-12 03:42:17 UTC) #4
kinaba
lgtm
5 years, 7 months ago (2015-05-12 03:43:00 UTC) #5
hirono
Thanks!
5 years, 7 months ago (2015-05-12 04:12:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130183003/40001
5 years, 7 months ago (2015-05-12 04:13:00 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 04:48:32 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 04:49:21 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/21c8c94ed1602209e7601d57b2e2c451d3294bbe
Cr-Commit-Position: refs/heads/master@{#329351}

Powered by Google App Engine
This is Rietveld 408576698