Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1130173002: Files.app: Relax condtion to skip OOBE demo mode. (Closed)

Created:
5 years, 7 months ago by hirono
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Relax condtion to skip OOBE demo mode. Due to Issue 398271 , we are disabling OOBE demo on test image, which makes it hard to test OOBE demo. We can relax the condition, so that it does not skip when derelict related switches are specified. BUG=485471 TEST=None Committed: https://crrev.com/1ebecb847cc6da9a045ab7b39afede429f2adac2 Cr-Commit-Position: refs/heads/master@{#329339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/ui/webui/chromeos/login/demo_mode_detector.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
hirono
@rkc - PTAL, thanks!
5 years, 7 months ago (2015-05-07 10:58:34 UTC) #2
rkc
lgtm
5 years, 7 months ago (2015-05-08 21:03:29 UTC) #3
rkc
(you will still need an owners review from chrome/browser/ui/webui/chromeos/login/OWNERS)
5 years, 7 months ago (2015-05-08 21:04:17 UTC) #4
hirono
@rkc - Thank you! @dzhioev - PTAL, thanks!
5 years, 7 months ago (2015-05-11 04:18:34 UTC) #6
dzhioev (left Google)
LGTM
5 years, 7 months ago (2015-05-11 19:49:59 UTC) #7
hirono
On 2015/05/11 19:49:59, dzhioev wrote: > LGTM Thank you!
5 years, 7 months ago (2015-05-12 02:50:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130173002/1
5 years, 7 months ago (2015-05-12 02:50:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 03:22:04 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 03:22:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ebecb847cc6da9a045ab7b39afede429f2adac2
Cr-Commit-Position: refs/heads/master@{#329339}

Powered by Google App Engine
This is Rietveld 408576698