Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issue 1130163005: More build fixes for Linux GN clobber after r329965 (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/runner/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jam
5 years, 7 months ago (2015-05-15 00:49:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130163005/1
5 years, 7 months ago (2015-05-15 00:50:38 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd7f632111ddf50cc0eff067f2c94563dc257e3e Cr-Commit-Position: refs/heads/master@{#330000}
5 years, 7 months ago (2015-05-15 00:54:36 UTC) #4
jam
Committed patchset #1 (id:1) manually as fd7f632111ddf50cc0eff067f2c94563dc257e3e (presubmit successful).
5 years, 7 months ago (2015-05-15 00:54:47 UTC) #5
Ben Goodger (Google)
5 years, 7 months ago (2015-05-15 02:05:18 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698