Issue 1130153005: Autofill: Document ExtractFieldsFromControlElements().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1130153005: Autofill: Document ExtractFieldsFromControlElements(). (Closed)

Created:
5 years, 7 months ago by Lei Zhang

Modified:
5 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Autofill: Document ExtractFieldsFromControlElements(). Also exit early in the function when possible. Committed: https://crrev.com/456e143645649f4f9c922c541a2b367d619bf28d Cr-Commit-Position: refs/heads/master@{#329735}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	components/autofill/content/renderer/form_autofill_util.cc	View		2 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130153005/1

5 years, 7 months ago (2015-05-13 21:16:09 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-13 22:24:42 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/456e143645649f4f9c922c541a2b367d619bf28d
Cr-Commit-Position: refs/heads/master@{#329735}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages