Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1130143002: Paste can not happen when search item is selected in tree. (Closed)

Created:
5 years, 7 months ago by Deepak
Modified:
5 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

We can not paste into search item in tree. As we don't have proper id for getting parent node while update paste when we types in search box and selected item is searchTreeItem. BUG=485459 Committed: https://crrev.com/61d8f0ea8d3e907240edbd77dd83e372ebf542e3 Cr-Commit-Position: refs/heads/master@{#328738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Deepak
As we can paste in the search view, Changes done for bmm.tree, as it is ...
5 years, 7 months ago (2015-05-07 08:07:17 UTC) #2
Bernhard Bauer
lgtm
5 years, 7 months ago (2015-05-07 10:34:39 UTC) #3
Deepak
On 2015/05/07 10:34:39, Bernhard Bauer wrote: > lgtm Thanks
5 years, 7 months ago (2015-05-07 10:35:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130143002/1
5 years, 7 months ago (2015-05-07 10:35:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 10:38:51 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 10:39:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61d8f0ea8d3e907240edbd77dd83e372ebf542e3
Cr-Commit-Position: refs/heads/master@{#328738}

Powered by Google App Engine
This is Rietveld 408576698