Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: src/pending-compilation-error-handler.h

Issue 1130133003: Migrate error messages, part 12. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@messages_11
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/pattern-rewriter.cc ('k') | src/pending-compilation-error-handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pending-compilation-error-handler.h
diff --git a/src/pending-compilation-error-handler.h b/src/pending-compilation-error-handler.h
index c75f23d0394f3be362b132d1d24e70ac6f105030..6190d49f5294dbeec59ddb1108d389443fa440b1 100644
--- a/src/pending-compilation-error-handler.h
+++ b/src/pending-compilation-error-handler.h
@@ -8,6 +8,7 @@
#include "src/base/macros.h"
#include "src/globals.h"
#include "src/handles.h"
+#include "src/messages.h"
namespace v8 {
namespace internal {
@@ -24,13 +25,14 @@ class PendingCompilationErrorHandler {
: has_pending_error_(false),
start_position_(-1),
end_position_(-1),
- message_(nullptr),
+ message_(MessageTemplate::kNone),
arg_(nullptr),
char_arg_(nullptr),
error_type_(kSyntaxError) {}
void ReportMessageAt(int start_position, int end_position,
- const char* message, const char* arg = nullptr,
+ MessageTemplate::Template message,
+ const char* arg = nullptr,
ParseErrorType error_type = kSyntaxError) {
if (has_pending_error_) return;
has_pending_error_ = true;
@@ -43,7 +45,8 @@ class PendingCompilationErrorHandler {
}
void ReportMessageAt(int start_position, int end_position,
- const char* message, const AstRawString* arg,
+ MessageTemplate::Template message,
+ const AstRawString* arg,
ParseErrorType error_type = kSyntaxError) {
if (has_pending_error_) return;
has_pending_error_ = true;
@@ -56,7 +59,7 @@ class PendingCompilationErrorHandler {
}
void ReportMessageAt(int start_position, int end_position,
- const char* message, Handle<String> arg,
+ MessageTemplate::Template message, Handle<String> arg,
ParseErrorType error_type = kSyntaxError) {
if (has_pending_error_) return;
has_pending_error_ = true;
@@ -77,7 +80,7 @@ class PendingCompilationErrorHandler {
bool has_pending_error_;
int start_position_;
int end_position_;
- const char* message_;
+ MessageTemplate::Template message_;
const AstRawString* arg_;
const char* char_arg_;
Handle<String> handle_arg_;
« no previous file with comments | « src/pattern-rewriter.cc ('k') | src/pending-compilation-error-handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698