Issue 1130123007: Revert of Debugger: preserve stepping state after evaluating breakpoint condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1130123007: Revert of Debugger: preserve stepping state after evaluating breakpoint condition. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach

Modified:
5 years, 7 months ago

Reviewers:
ulan, yurys, Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Debugger: preserve stepping state after evaluating breakpoint condition. (patchset #1 id:1 of https://codereview.chromium.org/1132643004/) Reason for revert: [Sheriff] This breaks TSAN (makes some tests marked as flaky permanently fail): http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/3882 Original issue's description: > Debugger: preserve stepping state after evaluating breakpoint condition. > > R=ulan@chromium.org, yurys@chromium.org > BUG=chromium:467180 > LOG=N TBR=ulan@chromium.org,yurys@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:467180 Committed: https://crrev.com/f453416b7f4d677fa3ce9bbda0cb1185400ef400 Cr-Commit-Position: refs/heads/master@{#28436}

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -67 lines)			Patch
M	src/debug.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	src/debug.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	test/mjsunit/regress/regress-crbug-467180.js	View	1 chunk	+0 lines, -41 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of Debugger: preserve stepping state after evaluating breakpoint condition.

5 years, 7 months ago (2015-05-17 06:21:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130123007/1

5 years, 7 months ago (2015-05-17 06:21:38 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-18 11:03:59 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f453416b7f4d677fa3ce9bbda0cb1185400ef400
Cr-Commit-Position: refs/heads/master@{#28436}