Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1130123006: Perform SkPicture analysis lazily. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, junchao.han, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Perform SkPicture analysis lazily. I realized when writing the comment on https://crrev.com/1135363002/ that I'd really just sketched out the entire thing, so I couldn't help but actually write up a working CL. How does this do for your benchmark? BUG=chromium:487075 Committed: https://skia.googlesource.com/skia/+/c30806f9f16e6400036fdc25842b73a9d2a41cb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M include/core/SkPicture.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/core/SkPicture.cpp View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130123006/1
5 years, 7 months ago (2015-05-13 13:46:28 UTC) #2
mtklein_C
5 years, 7 months ago (2015-05-13 13:53:23 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 13:55:20 UTC) #7
reed1
api lgtm
5 years, 7 months ago (2015-05-13 15:06:51 UTC) #9
junchao.han
The patch looks great and BrowserMark 2.1 SVG case will enjoy ~10% performance improvement on ...
5 years, 7 months ago (2015-05-14 01:41:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130123006/1
5 years, 7 months ago (2015-05-14 02:26:02 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 02:26:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c30806f9f16e6400036fdc25842b73a9d2a41cb3

Powered by Google App Engine
This is Rietveld 408576698