Use CCTestSuite for cc_blink_unittests

Use CCBlinkTestSuite for cc_blink_unittests

This CL fixes
WebLayerImplFixedBoundsTest.CompareToWebLayerImplComplex and
WebLayerImplFixedBoundsTest.CompareToWebLayerImplSimple tests.

BUG=440441
R=enne, danakj

Committed: https://crrev.com/64e01b985f4d6553d9767cd9a15fbccb08687d6f
Cr-Commit-Position: refs/heads/master@{#330167}

[danakj, 2015-05-13 16:51:05]

Can you explain how this fixes the tests?

[Lof, 2015-05-14 12:08:04]

On 2015/05/13 16:51:05, danakj wrote:
> Can you explain how this fixes the tests?

https://code.google.com/p/chromium/codesearch#chromium/src/cc/blink/web_layer...
Here we try to create FakeLayerTreeHost.

https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/fake_layer...
FakeLayerTreeHost tries to create FakeImplProxy.

https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/fake_impl_...
FakeImplProxy tries to get pointer SingleThreadTaskRunner.

https://code.google.com/p/chromium/codesearch#chromium/src/base/thread_task_r...
Here current pointer is null, so we crash on DCHECK in Debug or on return in
Release.

Pointer is null because we need to create base::MessageLoop.

https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/cc_test_su...
Here we create base::MessageLoop.

https://code.google.com/p/chromium/codesearch#chromium/src/base/message_loop/...
And here we set a pointer.

So I think CCTestSuite is great to use not only in cc_unittests, but also in
cc_blink_unittests.

[danakj, 2015-05-14 16:49:34]

Great, thanks for the explanation. Can you add a CCBlinkTestSuite in
cc/blink/test/ instead of using the cc/ one?

On Thu, May 14, 2015 at 5:08 AM, <lof84@yandex-team.ru> wrote:

> On 2015/05/13 16:51:05, danakj wrote:
>
>> Can you explain how this fixes the tests?
>>
>
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/cc/blink/web_layer...
> Here we try to create FakeLayerTreeHost.
>
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/fake_layer...
> FakeLayerTreeHost tries to create FakeImplProxy.
>
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/fake_impl_...
> FakeImplProxy tries to get pointer SingleThreadTaskRunner.
>
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/thread_task_r...
> Here current pointer is null, so we crash on DCHECK in Debug or on return
> in
> Release.
>
> Pointer is null because we need to create base::MessageLoop.
>
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/cc_test_su...
> Here we create base::MessageLoop.
>
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/message_loop/...
> And here we set a pointer.
>
> So I think CCTestSuite is great to use not only in cc_unittests, but also
> in
> cc_blink_unittests.
>
> https://codereview.chromium.org/1130123005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Lof, 2015-05-15 11:23:08]

On 2015/05/14 16:49:34, danakj wrote:
> Great, thanks for the explanation. Can you add a CCBlinkTestSuite in
> cc/blink/test/ instead of using the cc/ one?

Done!

[danakj, 2015-05-15 17:03:02]

LGTM

[Lof, 2015-05-15 18:29:15]

The CQ bit was checked by lof84@yandex-team.ru

[commit-bot: I haz the power, 2015-05-15 18:29:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130123005/20001

[commit-bot: I haz the power, 2015-05-15 18:53:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 18:53:08]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Lof, 2015-05-15 19:11:23]

Explicit deps in gn

[Lof, 2015-05-15 19:11:27]

The CQ bit was checked by lof84@yandex-team.ru

[Lof, 2015-05-15 19:11:27]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1130123005/#ps40001
(title: "Explicit deps in gn")

[commit-bot: I haz the power, 2015-05-15 19:13:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130123005/40001

[commit-bot: I haz the power, 2015-05-15 19:32:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-15 19:33:25]

Patchset 3 (id:??) landed as
https://crrev.com/64e01b985f4d6553d9767cd9a15fbccb08687d6f
Cr-Commit-Position: refs/heads/master@{#330167}