Source/modules/serviceworkers/ServiceWorkerContainer.h - Issue 1130113006: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (3/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.h

Issue 1130113006: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (3/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remove custom bindings Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/constructors/serviceworker-message-event-constructor.html ('K') | « Source/modules/modules.gypi ('k') | Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('j') | Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerContainer.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.h b/Source/modules/serviceworkers/ServiceWorkerContainer.h

index 8ec0ccbeec24e1736023f1511a4b8674b9fc8b63..b1c7c8f63ad6069cb163ca8849763ade43ac919c 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainer.h

+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.h

@@ -77,13 +77,14 @@ public:

// WebServiceWorkerProviderClient overrides.

virtual void setController(WebServiceWorker*, bool shouldNotifyControllerChange) override;

- virtual void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray&) override;

+ virtual void dispatchMessageEvent(WebServiceWorker*, const WebString& message, const WebMessagePortChannelArray&) override;

// EventTarget overrides.

virtual ExecutionContext* executionContext() const override { return ContextLifecycleObserver::executionContext(); }

virtual const AtomicString& interfaceName() const override;

DEFINE_ATTRIBUTE_EVENT_LISTENER(controllerchange);

+ DEFINE_ATTRIBUTE_EVENT_LISTENER(message);

private:

explicit ServiceWorkerContainer(ExecutionContext*);