Source/modules/serviceworkers/ServiceWorkerMessageEventInit.idl - Issue 1130113006: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (3/3).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/serviceworkers/ServiceWorkerMessageEventInit.idl

Issue 1130113006: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (3/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: make union type only on stack Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl ('K') | « Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl ('k') | public/platform/WebServiceWorkerProviderClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworke rmessage-event-init-dictionary

	6

	7 dictionary ServiceWorkerMessageEventInit : EventInit {

	8 any data;

	9 DOMString origin;

	10 DOMString lastEventId;

	11 (ServiceWorker or MessagePort)? source;

	12 sequence<MessagePort> ports;
	haraken 2015/06/25 04:18:49 Is it intentional that you use sequence<MessagePor Is it intentional that you use sequence<MessagePort> in ServiceWorkerMessageEventInit but use MessagePort[] in ServiceWorkerMessageEvent? xiang 2015/06/29 02:32:24 Yes, this's defined by spec to use "sequence" in S Show quoted text On 2015/06/25 04:18:49, haraken wrote: > > Is it intentional that you use sequence<MessagePort> in > ServiceWorkerMessageEventInit but use MessagePort[] in > ServiceWorkerMessageEvent? Yes, this's defined by spec to use "sequence" in ServiceWorkerMessageEventInit. haraken 2015/06/29 02:37:14 +bashi@: Is it common to use a sequence in an Even Show quoted text On 2015/06/29 02:32:24, xiang wrote: > On 2015/06/25 04:18:49, haraken wrote: > > > > Is it intentional that you use sequence<MessagePort> in > > ServiceWorkerMessageEventInit but use MessagePort[] in > > ServiceWorkerMessageEvent? > > Yes, this's defined by spec to use "sequence" in ServiceWorkerMessageEventInit. +bashi@: Is it common to use a sequence in an EventInit but use an array in an Event?
	13 };

OLD	NEW