Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl - Issue 1130113006: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (3/3).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl

Issue 1130113006: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (3/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: make union type only on stack Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp ('K') | « Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerMessageEventInit.idl » ('j') | Source/modules/serviceworkers/ServiceWorkerMessageEventInit.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworke rmessage-event-interface

	6

	7 [

	8 Constructor(DOMString type, optional ServiceWorkerMessageEventInit eventInit Dict),

	9 Exposed=(Window, Worker),

	10 RuntimeEnabled=ServiceWorker,

	11 ] interface ServiceWorkerMessageEvent : Event {

	12 readonly attribute DOMString origin;

	13 readonly attribute DOMString lastEventId;

	14 readonly attribute (ServiceWorker or MessagePort)? source;

	15 [Custom=Getter] readonly attribute any data;
	falken 2015/06/25 03:49:35 Can you put these in the same order as the spec, f Can you put these in the same order as the spec, for easier comparison? xiang 2015/06/29 02:32:24 Done. Show quoted text On 2015/06/25 03:49:35, falken wrote: > Can you put these in the same order as the spec, for easier comparison? Done.
	16 readonly attribute MessagePort[] ports;
	falken 2015/06/25 03:49:35 The spec is "MessagePort[]?" The spec is "MessagePort[]?" haraken 2015/06/25 04:18:49 Can we add a test for this? Show quoted text On 2015/06/25 03:49:35, falken wrote: > The spec is "MessagePort[]?" Can we add a test for this? xiang 2015/06/29 02:32:24 Done. Show quoted text On 2015/06/25 03:49:35, falken wrote: > The spec is "MessagePort[]?" Done. xiang 2015/06/29 02:32:24 The fast/events/constructors/serviceworker-message Show quoted text On 2015/06/25 04:18:49, haraken wrote: > On 2015/06/25 03:49:35, falken wrote: > > The spec is "MessagePort[]?" > > Can we add a test for this? The fast/events/constructors/serviceworker-message-event-constructor.html will verfiy this change.
	17 };

OLD	NEW