Source/modules/serviceworkers/ServiceWorkerMessageEventInit.idl - Issue 1130113006: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (3/3).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/serviceworkers/ServiceWorkerMessageEventInit.idl

Issue 1130113006: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (3/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address #4， #14 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#fe tch-event-interface	5 // https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworke rmessage-event-section

6	6

7 dictionary FetchEventInit : ExtendableEventInit {	7 dictionary ServiceWorkerMessageEventInit : EventInit {
	haraken 2015/05/26 00:25:52 This is a question against the spec, but why doesn This is a question against the spec, but why doesn't ServiceWorkerMessageEventInit inherit from MessageEventInit? Also ServiceWorkerMessageEvent duplicates a lot of code from MessageEvent. I'm curious why ServiceWorkerMessageEvent is not speced so that it inherits from MessageEvent. jungkees 2015/05/27 10:51:33 falken brought me here. Subclassing MessageEvent Show quoted text On 2015/05/26 00:25:52, haraken wrote: > > This is a question against the spec, but why doesn't > ServiceWorkerMessageEventInit inherit from MessageEventInit? > > Also ServiceWorkerMessageEvent duplicates a lot of code from MessageEvent. I'm > curious why ServiceWorkerMessageEvent is not speced so that it inherits from > MessageEvent. falken brought me here. Subclassing MessageEvent interface was the way we tried first, but it ends up wonfix: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28199 One of the reasons is the type of source attribute is radically different from that of the MessageEvent, and extending HTML text has not happened. Another reason is ExtendableMessageEvent (a friend of ServiceWorkerMessageEvent) had to extend both ExtendableEvent (for its waitUntil() method in SW context) and MessageEvent (for its source attribute as mentioned). We couldn't do it with subclassing MessageEvent and redefine waitUntil() in the subclass apart from the ExtendableEvent interface. Please see some of the rationale discussed in the spec issue here: https://github.com/slightlyoff/ServiceWorker/issues/669#issuecomment-88860069.
8 Request request;	8 any data;

9 Client client;	9 DOMString origin;

10 boolean isReload = false;	10 DOMString lastEventId;

	11 (ServiceWorker or MessagePort)? source;

	12 sequence<MessagePort> ports;

11 };	13 };

OLD	NEW

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl ('k') | public/platform/WebServiceWorkerProviderClient.h » ('j') | no next file with comments »