Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: chrome/browser/resources/settings/settings_drawer/settings_drawer.js

Issue 1130113005: Convert cr-settings-drawer to Polymer 0.8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ConvertSettingsMenu
Patch Set: add grdp Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_drawer/settings_drawer.js
diff --git a/chrome/browser/resources/settings/settings_drawer/settings_drawer.js b/chrome/browser/resources/settings/settings_drawer/settings_drawer.js
index 7cbd9da99f82244f2eedbee2ae58b8a70e44590a..16875d7bfd369ff81235dcec22f194fe75ae5d05 100644
--- a/chrome/browser/resources/settings/settings_drawer/settings_drawer.js
+++ b/chrome/browser/resources/settings/settings_drawer/settings_drawer.js
@@ -9,50 +9,53 @@
*
* Example:
*
- * <core-drawer-panel>
- * <cr-settings-drawer drawer selectedId="{{selectedId}}"
- * pages="{{pages}}">
+ * <paper-drawer-panel>
+ * <cr-settings-drawer drawer selected-id="{{selectedId}}"
+ * pages="[[pages]]">
* </cr-settings-drawer>
- * <cr-settings-main main selectedId="{{selectedId}}" pages="{{pages}}">
+ * <cr-settings-main main selected-id="{{selectedId}}" pages="[[pages]]">
* </cr-settings-main>
- * </core-drawer-panel>
+ * </paper-drawer-panel>
*
* @group Chrome Settings Elements
* @element cr-settings-drawer
*/
-Polymer('cr-settings-drawer', {
- publish: {
+Polymer({
+ is: 'cr-settings-drawer',
+
+ properties: {
/**
* Pages to include in the navigation.
- *
- * @attribute pages
- * @type Array<!Object>
- * @default null
+ * @type {!Array<!HTMLElement>}
*/
- pages: null,
+ pages: {
+ type: Array,
+ value: function() { return []; },
+ },
/**
* ID of the currently selected page.
- *
- * @attribute selectedId
- * @type string
- * default ''
+ * @type {string}
*/
- selectedId: '',
- },
-
- /** @override */
- created: function() {
- this.pages = [];
- },
+ selectedId: {
+ type: String,
+ notify: true,
+ },
- /**
- * @type {Object}
- * TODO(michaelpg): Create custom element and data source for user card.
- */
- user: {
- name: 'Chrome User',
- email: 'user@example.com',
- iconUrl: 'chrome://theme/IDR_PROFILE_AVATAR_23@1x',
+ /**
+ * @private {!Object}
+ * TODO(michaelpg): Create custom element and data source for user card.
+ */
+ user_: {
+ type: Object,
+ value: function() {
+ return {
+ name: 'Chrome User',
+ email: 'user@example.com',
+ iconUrl: 'chrome://theme/IDR_PROFILE_AVATAR_23@1x',
+ };
+ },
+ readOnly: true,
+ },
},
});

Powered by Google App Engine
This is Rietveld 408576698