chrome/browser/resources/settings/settings_drawer/settings_drawer.html - Issue 1130113005: Convert cr-settings-drawer to Polymer 0.8

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_drawer/settings_drawer.html

Issue 1130113005: Convert cr-settings-drawer to Polymer 0.8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ConvertSettingsMenu

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/settings_drawer/settings_drawer.css ('K') | « chrome/browser/resources/settings/settings_drawer/settings_drawer.css ('k') | chrome/browser/resources/settings/settings_drawer/settings_drawer.js » ('j') | chrome/browser/resources/settings/settings_drawer/settings_drawer.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v0_8/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v0_8/iron-flex-layout/classe s/iron-flex-layout.html">

2 <link rel="import" href="chrome://md-settings/settings_menu/settings_menu.html">	3 <link rel="import" href="chrome://md-settings/settings_menu/settings_menu.html">

3 <link rel="import" href="settings_drawer_style.html">

4	4

5 <polymer-element name="cr-settings-drawer" layout vertical>	5 <dom-module id="cr-settings-drawer">

	6 <link rel="import" type="css" href="settings_drawer.css">

6 <template>	7 <template>

7 <core-style ref="settingsDrawerStyle"></core-style>

8 <!-- TODO(michaelpg): Create a new user card component. -->	8 <!-- TODO(michaelpg): Create a new user card component. -->

9 <div id="user-card" class="medium" layout horizontal center>	9 <div id="user-card" class="layout horizontal center">

10 <img src="{{user.iconUrl}}">	10 <img src="[[user_.iconUrl]]">
	Jeremy Klein 2015/05/12 18:06:41 It probably doesn't matter in this case because sr It probably doesn't matter in this case because src has a property attached to it, but it's recommended to use $= when binding to native attributes: https://github.com/Polymer/polymer/blob/0.8-preview/PRIMER.md#binding-to-nati... michaelpg 2015/05/12 18:37:11 Done. Show quoted text On 2015/05/12 18:06:41, Jeremy Klein wrote: > It probably doesn't matter in this case because src has a property attached to > it, but it's recommended to use $= when binding to native attributes: > > https://github.com/Polymer/polymer/blob/0.8-preview/PRIMER.md#binding-to-nati... Done.
11 <div flex>	11 <div class="flex">

12 <div class="name">{{user.name}}</div>	12 <div class="name">[[user_.name]]</div>

13 <div class="email">{{user.email}}</div>	13 <div class="email">[[user_.email]]</div>

14 </div>	14 </div>

15 </div>	15 </div>

16 <cr-settings-menu flex selectedId="{{selectedId}}" pages="{{pages}}">	16 <cr-settings-menu class="flex" selectedId="{{selectedId}}"

	17 pages="[[pages]]">

17 </cr-settings-menu>	18 </cr-settings-menu>

18 </template>	19 </template>

19 <script src="settings_drawer.js"></script>	20 <script src="settings_drawer.js"></script>

20 </polymer-element>	21 </polymer-element>

OLD	NEW