Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: tests/isolate/isolate_negative_test.dart

Issue 11301046: Restructure pkg/unittest and pkg/webdriver to follow the pub conventions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/isolate/isolate_negative_test.dart
===================================================================
--- tests/isolate/isolate_negative_test.dart (revision 14313)
+++ tests/isolate/isolate_negative_test.dart (working copy)
@@ -4,9 +4,9 @@
// Dart test program for testing that isolates are spawned.
-#library('IsolateNegativeTest');
-#import('dart:isolate');
-#import('../../pkg/unittest/unittest.dart');
+library IsolateNegativeTest;
+import 'dart:isolate';
+import '../../pkg/unittest/lib/unittest.dart';
void entry() {
port.receive((ignored, replyTo) {
@@ -18,7 +18,7 @@
test("ensure isolate code is executed", () {
SendPort port = spawnFunction(entry);
port.call("foo").then(expectAsync1((message) {
- Expect.equals(true, "Expected fail"); // <=-------- Should fail here.
+ expect("Expected fail", isFail); // <=-------- Should fail here.
Siggi Cherem (dart-lang) 2012/10/31 20:54:02 isFail? isFalse? or replace with unittest.fail()
gram 2012/11/01 21:23:19 Yes, this should be isFalse; fixed. expect does n
Siggi Cherem (dart-lang) 2012/11/01 21:40:54 what I meant to say is that [unittest.fail] is a g
}));
});
}

Powered by Google App Engine
This is Rietveld 408576698