pkg/unittest/lib/matcher.dart - Issue 11301046: Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/unittest/lib/matcher.dart

Issue 11301046: Restructure pkg/unittest and pkg/webdriver to follow the pub conventions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 // TODO(gram) - when we can do package imports from within packages

	6 // without Dartdoc choking, this should be moved to a separate package.
	Siggi Cherem (dart-lang) 2012/10/31 20:54:02 I'm not sure I understand this TODO - we want matc I'm not sure I understand this TODO - we want matcher to still be distributed with unittest, so it should all be part of a single package gram 2012/11/01 21:23:19 Personally it seems to me it needn't be, and could Show quoted text On 2012/10/31 20:54:02, Siggi Cherem (dart-lang) wrote: > I'm not sure I understand this TODO - we want matcher to still be distributed > with unittest, so it should all be part of a single package Personally it seems to me it needn't be, and could be a whole separate package, but we can decide that later; I removed the comment.
	7

	8 library matcher;
	Siggi Cherem (dart-lang) 2012/10/31 20:54:02 we should add some top-level dartdocs to this libr we should add some top-level dartdocs to this library. gram 2012/11/01 21:23:19 Done. Show quoted text On 2012/10/31 20:54:02, Siggi Cherem (dart-lang) wrote: > we should add some top-level dartdocs to this library. Done.
	9

	10 part 'basematcher.dart';
	Siggi Cherem (dart-lang) 2012/10/31 20:54:02 I think we should create a src/ subdirectory and m I think we should create a src/ subdirectory and move all the parts there: library matcher; part 'src/core_matchers.dart'; ... We want the lib directory to just have what users will be importing from. gram 2012/11/01 21:23:19 Done. Show quoted text On 2012/10/31 20:54:02, Siggi Cherem (dart-lang) wrote: > I think we should create a src/ subdirectory and move all the parts there: > > library matcher; > > part 'src/core_matchers.dart'; > > ... > > We want the lib directory to just have what users will be importing from. Done.
	11 part 'collection_matchers.dart';

	12 part 'core_matchers.dart';

	13 part 'description.dart';

	14 part 'expect.dart';

	15 part 'future_matchers.dart';

	16 part 'interfaces.dart';

	17 part 'map_matchers.dart';

	18 part 'numeric_matchers.dart';

	19 part 'operator_matchers.dart';

	20 part 'string_matchers.dart';

	21
	Siggi Cherem (dart-lang) 2012/10/31 20:54:02 remove empty line remove empty line gram 2012/11/01 21:23:19 Done. Show quoted text On 2012/10/31 20:54:02, Siggi Cherem (dart-lang) wrote: > remove empty line Done.
OLD	NEW

« pkg/unittest/lib/html_print.dart ('K') | « pkg/unittest/lib/map_matchers.dart ('k') | pkg/unittest/lib/mock.dart » ('j') | pkg/unittest/lib/mock.dart » ('J')