Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 11301033: Notify AnalysisServer about save in RefactoringSaveHelper (Closed)

Created:
8 years, 1 month ago by scheglov
Modified:
8 years, 1 month ago
Reviewers:
messick
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Notify AnalysisServer about save in RefactoringSaveHelper R=messick@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14242

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -18 lines) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringSaveHelper.java View 3 chunks +36 lines, -0 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/CompilationUnitEditor.java View 4 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 1 month ago (2012-10-30 04:18:18 UTC) #1
messick
lgtm https://codereview.chromium.org/11301033/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringSaveHelper.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringSaveHelper.java (right): https://codereview.chromium.org/11301033/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringSaveHelper.java#newcode65 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringSaveHelper.java:65: */ It took me a while to understand ...
8 years, 1 month ago (2012-10-30 04:29:51 UTC) #2
scheglov
8 years, 1 month ago (2012-10-30 04:33:09 UTC) #3
https://codereview.chromium.org/11301033/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringSaveHelper.java
(right):

https://codereview.chromium.org/11301033/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/RefactoringSaveHelper.java:65:
*/
Thank you!

Powered by Google App Engine
This is Rietveld 408576698