Issue 1130103005: Ignore lint warning related to UseSparseArrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1130103005: Ignore lint warning related to UseSparseArrays

Created:
5 years, 7 months ago by wajahat

Modified:
5 years, 7 months ago

Reviewers:
jamesr, rmcilroy

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ignore lint warning related to UseSparseArrays The following warning has been reported ../../../../../tmp/tmp5eB08m/0/RouterImpl.java:60 Use `new LongSparseArray(...)` instead for better performance: UseSparseArrays [warning] private Map<Long, MessageReceiver> mResponders = new HashMap<Long, MessageReceiver>(); As MessageReceiver.getRequestId() returns Long and indeed Map are better compared to using Android sparse arrays as per the below discussion: https://groups.google.com/forum/?fromgroups=#!topic/android-developers/G-ceop4xp48 this warning can be ignored. BUG=None.

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/RouterImpl.java	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

wajahat

RouterImpl.java originally added in https://codereview.chromium.org/371603003/ Pl. review, thanks!

5 years, 7 months ago (2015-05-11 14:26:39 UTC) #2

jamesr

5 years, 7 months ago (2015-05-12 01:05:48 UTC) #3

This code is imported from the mojo repo.  Instructions for contributing patches
are here: https://github.com/domokit/mojo/blob/master/README.md

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages