Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130073005: Revert of Migrate error messages, part 10. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Migrate error messages, part 10. (patchset #2 id:20001 of https://codereview.chromium.org/1126043004/) Reason for revert: patch didn't apply correctly. Original issue's description: > Migrate error messages, part 10. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f > Cr-Commit-Position: refs/heads/master@{#28357} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/26cb29b891a36d6d89374cd22ab4e5708bda0d3f Cr-Commit-Position: refs/heads/master@{#28358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -251 lines) Patch
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api-natives.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/builtins.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M src/debug.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/elements.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M src/isolate.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/json.js View 2 chunks +6 lines, -2 lines 0 comments Download
M src/json-stringifier.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/messages.h View 6 chunks +0 lines, -35 lines 0 comments Download
M src/messages.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/messages.js View 4 chunks +20 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/objects.cc View 17 chunks +72 lines, -53 lines 0 comments Download
M src/runtime.js View 13 chunks +13 lines, -13 lines 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/runtime/runtime-date.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/messages.js View 5 chunks +1 line, -61 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Migrate error messages, part 10.
5 years, 7 months ago (2015-05-12 08:32:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130073005/1
5 years, 7 months ago (2015-05-12 08:33:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 08:33:34 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 08:33:49 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/26cb29b891a36d6d89374cd22ab4e5708bda0d3f
Cr-Commit-Position: refs/heads/master@{#28358}

Powered by Google App Engine
This is Rietveld 408576698