Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Issue 1130063004: Only print elements of a typed array if the buffer wasn't neutered (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
ulan, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only print elements of a typed array if the buffer wasn't neutered BUG=chromium:485534 R=yangguo@chromium.org LOG=n Committed: https://crrev.com/e7fcae36d337fb743007ae8d36abd9132e49f738 Cr-Commit-Position: refs/heads/master@{#28302}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/objects-printer.cc View 1 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-07 14:07:12 UTC) #1
ulan
lgtm, maybe add printing of the neutered state?
5 years, 7 months ago (2015-05-07 14:55:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130063004/20001
5 years, 7 months ago (2015-05-07 15:15:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-07 15:55:29 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 15:55:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7fcae36d337fb743007ae8d36abd9132e49f738
Cr-Commit-Position: refs/heads/master@{#28302}

Powered by Google App Engine
This is Rietveld 408576698