Update HTTP/2 ALTSVC wireformat from draft-04 to draft-06.

Update HTTP/2 ALTSVC wireformat from draft-04 to draft-06.

This CL lands server changes 92291593 and 92349257 by bnc.

BUG=488484
Committed: https://crrev.com/779dc7195682e87e323b3afd648c56e4773d3500
Cr-Commit-Position: refs/heads/master@{#330932}

[Bence, 2015-05-18 15:54:45]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2015-05-18 15:54:46]

Ryan, please help.  for (const auto& invalid_input : {"foo", "bar"}) is a
c++11-ism, what is the usual way of writing this in Chromium?  vector<string>
and push_backs, or helper functions in local namespace?  Thanks.

[Ryan Hamilton, 2015-05-18 16:16:23]

On 2015/05/18 15:54:46, Bence wrote:
> Ryan, please help.  for (const auto& invalid_input : {"foo", "bar"}) is a
> c++11-ism, what is the usual way of writing this in Chromium?  vector<string>
> and push_backs, or helper functions in local namespace?  Thanks.

It's an acceptable C++11-ism as far as I know. We use this notation in several
places in the QUIC code for example. Are you having build problems using it?

[Bence, 2015-05-18 16:31:59]

On 2015/05/18 16:16:23, Ryan Hamilton wrote:
> On 2015/05/18 15:54:46, Bence wrote:
> > Ryan, please help.  for (const auto& invalid_input : {"foo", "bar"}) is a
> > c++11-ism, what is the usual way of writing this in Chromium? 
vector<string>
> > and push_backs, or helper functions in local namespace?  Thanks.
> 
> It's an acceptable C++11-ism as far as I know. We use this notation in several
> places in the QUIC code for example. Are you having build problems using it?

Yes, I have difficulties, see two failures for Patch Set 2, for example [1]. 
(The third one is a build dependency whine.)  "error: cannot deduce type of
initializer list because std::initializer_list was not found; include
<initializer_list>".  initializer_list is C++11, I don't see it at [2], and I do
not see in included anywhere in src/net/.  I'm trying to specify the type
(instead of auto), maybe that helps.  Thanks.

[1]
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...
[2] http://chromium-cpp.appspot.com/

[Bence, 2015-05-18 19:00:30]

> It's an acceptable C++11-ism as far as I know. We use this notation in several
> places in the QUIC code for example. Are you having build problems using it?

No luck on this end.  Would you be so kind as to point me to such usage, I don't
seem to find it.  Sorry for the hassle.

[Ryan Hamilton, 2015-05-18 19:28:56]

On Mon, May 18, 2015 at 12:00 PM, <bnc@chromium.org> wrote:

> It's an acceptable C++11-ism as far as I know. We use this notation in
>> several
>> places in the QUIC code for example. Are you having build problems using
>> it?
>>
>
> No luck on this end.  Would you be so kind as to point me to such usage, I
> don't
> seem to find it.  Sorry for the hassle.
>
> https://codereview.chromium.org/1130053007/
>

​What error do you get?

https://code.google.com/p/chromium/codesearch#chromium/src/net/tools/quic/end...
​

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Bence, 2015-05-18 19:35:25]

> ​What error do you get?

See Patch Set 2, 4, and 5 outputs, for example:

http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...

>
https://code.google.com/p/chromium/codesearch#chromium/src/net/tools/quic/end...

kReno and kQBIC are of integral type, that's different.

[Ryan Hamilton, 2015-05-18 20:06:45]

On 2015/05/18 19:35:25, Bence wrote:
> > ​What error do you get?
> 
> See Patch Set 2, 4, and 5 outputs, for example:
> 
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...
> 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/net/tools/quic/end...
> 
> kReno and kQBIC are of integral type, that's different.

Ah I see. In that case, can you do:

const char* foo[] = { .... };
for (const char * element : foo) {

[Bence, 2015-05-19 18:19:38]

> Ah I see. In that case, can you do:
> 
> const char* foo[] = { .... };
> for (const char * element : foo) {

PTAL.  Thanks, that works.  *facepalm*

[Ryan Hamilton, 2015-05-19 19:11:59]

lgtm

[Bence, 2015-05-19 19:39:11]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-05-19 19:39:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130053007/100001

[commit-bot: I haz the power, 2015-05-19 20:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 20:37:09]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Bence, 2015-05-20 15:17:56]

Patchset #7 (id:120001) has been deleted

[Bence, 2015-05-20 15:22:03]

Patchset #7 (id:140001) has been deleted

[Bence, 2015-05-20 16:03:45]

Ryan, PTAL.  There seem to be some stubborn linker errors around templates, what
am I doing wrong?  Can you think of any better way of fixing it that the
workaround presented in Patch Set 8?  Thanks.

[Ryan Hamilton, 2015-05-20 22:41:16]

On 2015/05/20 16:03:45, Bence wrote:
> Ryan, PTAL.  There seem to be some stubborn linker errors around templates,
what
> am I doing wrong?  Can you think of any better way of fixing it that the
> workaround presented in Patch Set 8?  Thanks.

Your workaround sounds fine to me. LGTM

[Bence, 2015-05-21 11:51:06]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-05-21 11:51:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130053007/180001

[commit-bot: I haz the power, 2015-05-21 11:54:22]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2015-05-21 11:55:18]

Patchset 8 (id:??) landed as
https://crrev.com/779dc7195682e87e323b3afd648c56e4773d3500
Cr-Commit-Position: refs/heads/master@{#330932}