Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: PRESUBMIT.py

Issue 1130053006: Change presubmit script to not allow uploads at all (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index f850b03948c9b2e1a03a9960ef8f54a3bc2d9cb2..5db7d6bc5f324132d701659ceb8ae621c68dace0 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -8,11 +8,15 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into gcl.
"""
+MOVED_TO_GITHUB = ("The dart svn repo is no more, and is only here for a "
+ "grace period until dependent projects have moved off. The new repo "
+ "is located at https://github.com/dart-lang/sdk, alongside the rest "
+ "of the dart-lang repos. Commits to this repo will have no effect "
+ "and you should not do it.")
+
def CheckChangeOnCommit(input_api, output_api):
- results = []
- status_check = input_api.canned_checks.CheckTreeIsOpen(
- input_api,
- output_api,
- json_url='http://dart-status.appspot.com/current?format=json')
- results.extend(status_check)
- return results
+ return [output_api.PresubmitError(MOVED_TO_GITHUB)]
+
+def CheckChangeOnUpload(input_api, output_api):
+ return [output_api.PresubmitError(MOVED_TO_GITHUB)]
+
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698