Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1130043004: Remove in-process PDF related code from print preview. (Closed)

Created:
5 years, 7 months ago by raymes
Modified:
5 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove in-process PDF related code from print preview. BUG=303491 Committed: https://crrev.com/c70e12953f2a5205df209f2eac0ff3472887b802 Cr-Commit-Position: refs/heads/master@{#331338}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -163 lines) Patch
M chrome/browser/resources/print_preview/previewarea/preview_area.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/previewarea/preview_area.js View 10 chunks +28 lines, -158 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
raymes
5 years, 7 months ago (2015-05-07 07:21:02 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 7 months ago (2015-05-07 18:58:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130043004/1
5 years, 7 months ago (2015-05-08 01:33:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/55157)
5 years, 7 months ago (2015-05-08 02:52:02 UTC) #7
raymes
Aleksey: could you please take another look? I had to change checkPluginCompatibility_ to make it ...
5 years, 7 months ago (2015-05-08 04:35:44 UTC) #8
Aleksey Shlyapnikov
lgtm
5 years, 7 months ago (2015-05-08 18:37:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130043004/40001
5 years, 7 months ago (2015-05-11 00:00:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/64412)
5 years, 7 months ago (2015-05-11 02:35:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130043004/100001
5 years, 7 months ago (2015-05-26 07:09:02 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 7 months ago (2015-05-26 09:10:58 UTC) #21
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 09:11:56 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c70e12953f2a5205df209f2eac0ff3472887b802
Cr-Commit-Position: refs/heads/master@{#331338}

Powered by Google App Engine
This is Rietveld 408576698