Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: cc/layers/layer_impl.h

Issue 1130043003: [Sketch] CC Animations: Torpedo the old intrusive animation system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@implscroll
Patch Set: Delete more (headers and animation_registrar_ leftover) Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer.cc ('k') | cc/layers/layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer_impl.h
diff --git a/cc/layers/layer_impl.h b/cc/layers/layer_impl.h
index 59ccfda89a1266df99781b518807672606cdc639..98e87516614a56b54cd09a4d641b9754a3dce9a6 100644
--- a/cc/layers/layer_impl.h
+++ b/cc/layers/layer_impl.h
@@ -13,10 +13,6 @@
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "base/values.h"
-#include "cc/animation/animation_delegate.h"
-#include "cc/animation/layer_animation_controller.h"
-#include "cc/animation/layer_animation_value_observer.h"
-#include "cc/animation/layer_animation_value_provider.h"
#include "cc/base/cc_export.h"
#include "cc/base/region.h"
#include "cc/base/scoped_ptr_vector.h"
@@ -78,9 +74,7 @@ enum DrawMode {
DRAW_MODE_RESOURCELESS_SOFTWARE
};
-class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
- public LayerAnimationValueProvider,
- public AnimationDelegate {
+class CC_EXPORT LayerImpl {
public:
typedef SyncedProperty<AdditionGroup<gfx::ScrollOffset>> SyncedScrollOffset;
typedef LayerImplList RenderSurfaceListType;
@@ -100,28 +94,17 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
return make_scoped_ptr(new LayerImpl(tree_impl, id));
}
- ~LayerImpl() override;
+ virtual ~LayerImpl();
int id() const { return layer_id_; }
- // LayerAnimationValueProvider implementation.
- gfx::ScrollOffset ScrollOffsetForAnimation() const override;
-
- // LayerAnimationValueObserver implementation.
- void OnFilterAnimated(const FilterOperations& filters) override;
- void OnOpacityAnimated(float opacity) override;
- void OnTransformAnimated(const gfx::Transform& transform) override;
- void OnScrollOffsetAnimated(const gfx::ScrollOffset& scroll_offset) override;
- void OnAnimationWaitingForDeletion() override;
- bool IsActive() const override;
-
- // AnimationDelegate implementation.
- void NotifyAnimationStarted(base::TimeTicks monotonic_time,
- Animation::TargetProperty target_property,
- int group) override{};
- void NotifyAnimationFinished(base::TimeTicks monotonic_time,
- Animation::TargetProperty target_property,
- int group) override;
+ gfx::ScrollOffset ScrollOffsetForAnimation() const;
+
+ void OnFilterAnimated(const FilterOperations& filters);
+ void OnOpacityAnimated(float opacity);
+ void OnTransformAnimated(const gfx::Transform& transform);
+ void OnScrollOffsetAnimated(const gfx::ScrollOffset& scroll_offset);
+ bool IsActive() const;
// Tree structure.
LayerImpl* parent() { return parent_; }
@@ -574,14 +557,6 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
void ResetAllChangeTrackingForSubtree();
- LayerAnimationController* layer_animation_controller() {
- return layer_animation_controller_.get();
- }
-
- const LayerAnimationController* layer_animation_controller() const {
- return layer_animation_controller_.get();
- }
-
virtual SimpleEnclosedRegion VisibleContentOpaqueRegion() const;
virtual void DidBecomeActive();
@@ -824,9 +799,6 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
// This rect is in layer space.
gfx::RectF damage_rect_;
- // Manages animations for this layer.
- scoped_refptr<LayerAnimationController> layer_animation_controller_;
-
// Manages scrollbars for this layer
scoped_ptr<ScrollbarAnimationController> scrollbar_animation_controller_;
« no previous file with comments | « cc/layers/layer.cc ('k') | cc/layers/layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698