Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: ui/views/widget/widget.cc

Issue 1130033003: Make the minimize state work when creating a chrome window in CrOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on master Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/native_widget_aura_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget.cc
diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc
index c3c0252a7f91fe0a645dfa7be4deed08055e4bd7..9d9ee6b0d8201c24989a241a89a6ce5964298e8d 100644
--- a/ui/views/widget/widget.cc
+++ b/ui/views/widget/widget.cc
@@ -632,8 +632,12 @@ void Widget::Show() {
!IsFullscreen()) {
native_widget_->ShowMaximizedWithBounds(initial_restored_bounds_);
} else {
- native_widget_->ShowWithWindowState(
- IsFullscreen() ? ui::SHOW_STATE_FULLSCREEN : saved_show_state_);
+ if (IsFullscreen()) {
oshima 2015/11/18 19:07:16 how about ui::ShowState show_state = IsFullscr
joone 2015/11/19 06:32:01 This code looks better so I applied this change to
+ native_widget_->ShowWithWindowState(ui::SHOW_STATE_FULLSCREEN);
+ } else {
+ native_widget_->ShowWithWindowState(
+ IsMinimized() ? ui::SHOW_STATE_MINIMIZED : saved_show_state_);
+ }
}
// |saved_show_state_| only applies the first time the window is shown.
// If we don't reset the value the window may be shown maximized every time
« no previous file with comments | « ui/views/widget/native_widget_aura_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698