chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 1130033003: Make the minimize state work when creating a chrome window in CrOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1130033003: Make the minimize state work when creating a chrome window in CrOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add widget->Show(), widget->Minimize() calls Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 2b51226c9b4dc97802e75d30be79e5fcfdd595c9..ef5803f6e3b94a160999890ea20c6f2c3970ebea 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -660,13 +660,6 @@ bool WindowsCreateFunction::RunSync() {

WindowController* controller = new_window->extension_window_controller();

-#if defined(OS_CHROMEOS)

- // For ChromeOS, manually Minimize(). Because minimzied window is not

- // considered to create new window. See http://crbug.com/473228.

- if (create_params.initial_show_state == ui::SHOW_STATE_MINIMIZED)

- new_window->window()->Minimize();

-#endif

if (new_window->profile()->IsOffTheRecord() &&

!GetProfile()->IsOffTheRecord() && !include_incognito()) {

// Don't expose incognito windows if extension itself works in non-incognito

« no previous file with comments | « no previous file | ui/views/widget/native_widget_aura.cc » ('j') | ui/views/widget/native_widget_aura_unittest.cc » ('J')