Make the minimize state work when creating a chrome window in CrOS

ui/views/widget/native_widget_aura.cc

Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index bf113e6e119de7bcb3ab99b2f21a1d185eba9ef7..234c285c984c49c87638cbad6748551fc8b5cf07 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -484,12 +484,14 @@ void NativeWidgetAura::ShowWithWindowState(ui::WindowShowState state) {
   if (!window_)
     return;
 
-  if (state == ui::SHOW_STATE_MAXIMIZED || state == ui::SHOW_STATE_FULLSCREEN)
-    window_->SetProperty(aura::client::kShowStateKey, state);
+  window_->SetProperty(aura::client::kShowStateKey, state);
   window_->Show();
   if (delegate_->CanActivate()) {
-    if (state != ui::SHOW_STATE_INACTIVE)
+    if (state != ui::SHOW_STATE_INACTIVE) {
       Activate();
+      if (state == ui::SHOW_STATE_MINIMIZED)

[tapted, 2015/05/29 00:57:42]

Sorry - I meant this should be part of the existing condition statement (rather
than a new condition statement).

i.e. on line 490

if (state != ui::SHOW_STATE_INACTIVE && state != ui::SHOW_STATE_MINIMIZED) {

Rationale: if the initial show state is minimized, the window shouldn't be
activated at all.

It should be unnecessary to call Minimize() after the SetProperty(..) call on
line 487, since it will do exactly the same thing.

[joone, 2015/05/29 01:11:27]

Minimized() should be called. Without calling it, 'minimized' state doesn't
work. There seems no way to minimize a window initially.
Instead, we open a window and minimize it forcibly.

[tapted, 2015/05/29 01:25:12]

Can you find out why? i.e. What is "undoing" the call to SetProperty in line
487. Maybe you need to set a breakpoint in aura::Window::SetProperty to find
out.

Maybe that will lead to a nicer fix.

Maybe it's not be nicer, in which case it probably doesn't make sense to call
SetProperty() until after the call to Show() (i.e. move line 488 down to line
500). Maybe that breaks other things, but we need a proper understanding of the
problem before trying to fix it.

[oshima, 2015/05/29 09:24:21]

This is because showing minimized window will unminimize the window.
(In other words, it does not make sense to "Show" minimized window because
it's hidden)
You can simply skip the show if the minimized state is requested.

+        Minimize();
+    }
     // SetInitialFocus() should be always be called, even for
     // SHOW_STATE_INACTIVE. If the window has to stay inactive, the method will
     // do the right thing.