Make the minimize state work when creating a chrome window in CrOS

chrome/browser/extensions/api/tabs/tabs_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 641 matching lines @@
   if (!saw_focus_key && create_panel)
     focused = false;
 
   if (focused)
     new_window->window()->Show();
   else
     new_window->window()->ShowInactive();
 
   WindowController* controller = new_window->extension_window_controller();
 
-#if defined(OS_LINUX) || defined(OS_CHROMEOS)
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   // On Desktop Linux, window managers may ignore hints until the X11 window is
   // mapped, which happens in the blocking call to Show() above.
   // DesktopWindowTreeHostX11 currently only checks for an attempt to maximize
   // once mapped, but not minimize or fullscreen.

[tapted, 2015/05/26 23:25:30]

I think minimize was added to DWTHX11's ShowWindowWithState in
http://crrev.com/329764 so the Minimize() below should now be redundant on
Desktop Linux as well.

I.e. this entire #if block should be able to be deleted now.

Likely the one below for fullscreen can go too, since handling for that was also
added in r329764.

[joone, 2015/05/27 17:50:21]

Can I create a separated CL for the Desktop Linux case? Because the below code
that handles ui::SHOW_STATE_FULLSCREEN can be removed together.

-  // For ChromeOS, manually Minimize(). Because minimzied window is not
-  // considered to create new window. See http://crbug.com/473228.
   if (create_params.initial_show_state == ui::SHOW_STATE_MINIMIZED)
     new_window->window()->Minimize();
 #endif
 #if (defined(OS_LINUX) && !defined(OS_CHROMEOS))
   // On Desktop Linux managers don't handle fullscreen state to
   // create window for now.
   if (create_params.initial_show_state == ui::SHOW_STATE_FULLSCREEN)
     controller->SetFullscreenMode(true, extension()->url());
 #endif
 
@@ skipping 1326 matching lines @@
   ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
   zoom_settings.default_zoom_factor.reset(new double(
       content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel())));
 
   results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions