Make the minimize state work when creating a chrome window in CrOS

ui/views/widget/native_widget_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_aura.h"
 
 #include "base/bind.h"
 #include "base/strings/string_util.h"
 #include "third_party/skia/include/core/SkRegion.h"
 #include "ui/aura/client/aura_constants.h"
@@ skipping 466 matching lines @@
   ShowWithWindowState(ui::SHOW_STATE_MAXIMIZED);
 }
 
 void NativeWidgetAura::ShowWithWindowState(ui::WindowShowState state) {
   if (!window_)
     return;
 
   if (state == ui::SHOW_STATE_MAXIMIZED || state == ui::SHOW_STATE_FULLSCREEN ||
       state == ui::SHOW_STATE_DOCKED) {
     window_->SetProperty(aura::client::kShowStateKey, state);
   }

[sadrul, 2015/10/07 16:32:54]

In earlier patchsets, the property was being set unconditionally. Can you
explain why it is necessary to remove that change? Please get another review
from oshima@ for this as well.

[varkha, 2015/10/07 18:16:57]

BrowserRemembersDockedState tests were failing because the tests expect a
browser window to have NORMAL state upon creation (rather than allowing DEFAULT
state to be committed). Probably the other test failures had a similar reason. 
It could be that NORMAL and DEFAULT should be the only states excluded since
MINIMIZED is handled below.
I have tried replacing the condition with this:
  if (state != ui::SHOW_STATE_NORMAL && state != ui::SHOW_STATE_DEFAULT)
and the 4 interactive_ui_tests that were failing are passing but I didn't run
the full try jobs.

[joone, 2015/10/16 07:29:49]

I thought that we could remove this condition, but I saw that some test cases
failed due to my change. So I just removed my change to recover the orignial
code.

[oshima, 2015/11/18 19:07:16]

I'm looking into these failures now to see if we can eliminate the condition.

   window_->Show();
   if (delegate_->CanActivate()) {
     if (state != ui::SHOW_STATE_INACTIVE)
       Activate();
     // SetInitialFocus() should be always be called, even for
     // SHOW_STATE_INACTIVE. If the window has to stay inactive, the method will
     // do the right thing.
     SetInitialFocus(state);
   }
+
+  // On desktop aura, a window is activated first even when it is shown as
+  // minimized. Do the same for consistency.
+  if (state == ui::SHOW_STATE_MINIMIZED)
+    Minimize();
 }
 
 bool NativeWidgetAura::IsVisible() const {
   return window_ && window_->IsVisible();
 }
 
 void NativeWidgetAura::Activate() {
   if (!window_)
     return;
 
@@ skipping 656 matching lines @@
   l10n_util::AdjustUIFont(&(ncm.lfCaptionFont));
   base::win::ScopedHFONT caption_font(CreateFontIndirect(&(ncm.lfCaptionFont)));
   return gfx::FontList(gfx::Font(caption_font));
 #else
   return gfx::FontList();
 #endif
 }
 
 }  // namespace internal
 }  // namespace views