Make the minimize state work when creating a chrome window in CrOS

ui/views/widget/native_widget_aura_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_aura.h"
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 82 matching lines @@
   parent->SetBounds(gfx::Rect(20, 40, 480, 320));
   scoped_ptr<Widget> widget(new Widget());
   NativeWidgetAura* window = Init(parent.get(), widget.get());
   window->CenterWindow(gfx::Size(500, 600));
 
   // |window| should be no bigger than |parent|.
   EXPECT_EQ("20,40 480x320", window->GetNativeWindow()->bounds().ToString());
   widget->CloseNow();
 }
 
+TEST_F(NativeWidgetAuraTest, CreateMinimized) {
+  Widget::InitParams params(Widget::InitParams::TYPE_WINDOW);
+  params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+  params.parent = NULL;
+  params.context = root_window();
+  params.show_state = ui::SHOW_STATE_MINIMIZED;
+  params.bounds.SetRect(0, 0, 1024, 800);
+  scoped_ptr<Widget> widget(new Widget());
+  widget->Init(params);
+  widget->Show();
+  widget->Minimize();

[joone, 2015/07/01 00:05:42]

Now, this test case is almost like the change in ShowWithWindowState().

[sadrul, 2015/07/01 03:50:56]

Isn't the purpose of this CL to make sure Show() does the right thing, and an
explicit call to Minimize() isn't necessary? Isn't that the change you are
making in tabs_api.cc too? Why do we need to call Minimize() here, then?

[joone, 2015/07/01 22:50:15]

Yes, Minimized() should not be necessary, but the show_state can be changed to
SHOW_STATE_DEFAULT in Widget::Show() by passing  saved_show_state_ to
ShowWithWindowState(). I think Widget::Show() should consider
SHOW_STATE_MINIMIZED state like SHOW_STATE_FULLSCREEN state.

+
+  EXPECT_TRUE(widget->IsMinimized());
+  widget->CloseNow();
+}
+
 class TestLayoutManagerBase : public aura::LayoutManager {
  public:
   TestLayoutManagerBase() {}
   ~TestLayoutManagerBase() override {}
 
   // aura::LayoutManager:
   void OnWindowResized() override {}
   void OnWindowAddedToLayout(aura::Window* child) override {}
   void OnWillRemoveWindowFromLayout(aura::Window* child) override {}
   void OnWindowRemovedFromLayout(aura::Window* child) override {}
@@ skipping 352 matching lines @@
   delegate->ClearGotMove();
   // Simulate a maximize with animation.
   delete widget->GetNativeView()->RecreateLayer().release();
   widget->SetBounds(gfx::Rect(0, 0, 500, 500));
   EXPECT_TRUE(delegate->got_move());
   widget->CloseNow();
 }
 
 }  // namespace
 }  // namespace views